Update Protobuf DSL Readme #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to raise awareness to possible type checking issues and resolve Shopify#1090
Morriar
reviewed
Aug 2, 2022
| @@ -50,3 +50,9 @@ class Cart | |||
| def number_value=(value); end | |||
| end | |||
| ~~~ | |||
|
|
|||
There was a problem hiding this comment.
This file is generated, you'll have to move the note to https://github.com/Shopify/tapioca/blob/main/lib/tapioca/dsl/compilers/protobuf.rb#L62.
There was a problem hiding this comment.
Whoops 🤦 Thanks for the notification, hopefully fixed it now.
Morriar
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to raise awareness to possible type checking issues and resolve #1090
Motivation
Implementation
Tests