Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yard-sorbet #1134

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Bump yard-sorbet #1134

merged 2 commits into from
Aug 24, 2022

Conversation

dduugg
Copy link
Contributor

@dduugg dduugg commented Aug 24, 2022

Motivation

yard-sorbet v0.7.0 was just released, which includes a typo fix that will break an existing test. I'm upgrading it and fixing the test in this PR, rather than wait for dependabot to flag the change.

Implementation

N/A

Tests

N/A

cc @KaanOzkan

@dduugg dduugg requested a review from a team as a code owner August 24, 2022 16:04
Copy link
Collaborator

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Morriar
Copy link
Collaborator

Morriar commented Aug 24, 2022

You'll need to update the RBIs for gems using bundle exec tapioca gems.

@dduugg
Copy link
Contributor Author

dduugg commented Aug 24, 2022

You'll need to update the RBIs for gems using bundle exec tapioca gems.

Thanks, done!

@paracycle paracycle merged commit 1751a56 into Shopify:main Aug 24, 2022
@dduugg dduugg deleted the bump-yard-sorbet branch August 25, 2022 03:34
@shopify-shipit shopify-shipit bot temporarily deployed to production August 31, 2022 14:40 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to 0-10-stable September 14, 2022 02:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants