Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump sorbet-static-and-runtime from 0.5.10326 to 0.5.10370" #1137

Conversation

KaanOzkan
Copy link
Contributor

@KaanOzkan KaanOzkan commented Aug 29, 2022

Reverts #1135 as we lose platform specific versions which are useful in local development.

@KaanOzkan KaanOzkan requested a review from a team as a code owner August 29, 2022 14:52
Copy link
Collaborator

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we temporarily disable Rubocop on this gem until the problem is fixed upstream? We maybe accidentally merge the next bump and find ourselves in the same situation again.

@KaanOzkan
Copy link
Contributor Author

Should we temporarily disable Rubocop on this gem until the problem is fixed upstream? We maybe accidentally merge the next bump and find ourselves in the same situation again.

I assume you mean dependabot. If we were able to close it company wide I'd definitely be in favour of that. For our projects I'm responsible of bumps this week and I can be vigilant since problem is assumed to be fixed by the end of the week. However, I'm not against skipping it for Tapioca.

@KaanOzkan KaanOzkan merged commit ce00fb9 into main Aug 29, 2022
@KaanOzkan KaanOzkan deleted the revert-1135-dependabot/bundler/sorbet-static-and-runtime-0.5.10370 branch August 29, 2022 15:54
@shopify-shipit shopify-shipit bot temporarily deployed to production August 31, 2022 14:40 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to 0-10-stable September 14, 2022 02:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants