Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore tmp directory in generated Sorbet configuration #1353

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

salmanasiddiqui
Copy link
Contributor

Motivation

  • Potentially speed up dev tc on local envs which can accumulate alot of stuff in tmp
  • Avoid random errors from tmp directory

For https://github.com/Shopify/shopify/pull/399463

@salmanasiddiqui salmanasiddiqui self-assigned this Jan 12, 2023
@salmanasiddiqui salmanasiddiqui requested a review from a team as a code owner January 12, 2023 19:51
Copy link
Collaborator

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Morriar
Copy link
Collaborator

Morriar commented Jan 12, 2023

It seems we have a few tests related to this you'll need to update.

@Morriar Morriar merged commit 225ae85 into main Jan 12, 2023
@Morriar Morriar deleted the salmanasiddiqui-patch-1 branch January 12, 2023 20:31
@paracycle paracycle changed the title ignore tmp directory when initializing sorbet config Ignore tmp directory in generated Sorbet configuration Feb 15, 2023
@shopify-shipit shopify-shipit bot temporarily deployed to production February 21, 2023 12:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants