Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach ActiveRecordColumns compiler about virtual attributes #1360

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Teach ActiveRecordColumns compiler about virtual attributes #1360

merged 1 commit into from
Jan 18, 2023

Conversation

bdewater
Copy link
Contributor

Motivation

Closes #1351

Implementation

_default_attributes contains the contents of columns_hash and virtual attributes, see

Tests

Test added.

@bdewater bdewater requested a review from a team as a code owner January 17, 2023 13:16
paracycle
paracycle reviewed Jan 17, 2023
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

lib/tapioca/dsl/compilers/active_record_columns.rb Outdated Show resolved Hide resolved
paracycle
paracycle approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@paracycle
Copy link
Member

Ok, I tested this against Core and it actually added many attributes that we were missing into DSL files. Thanks for the contribution @bdewater!

@paracycle paracycle merged commit a3b83c2 into Shopify:main Jan 18, 2023
@bdewater bdewater deleted the ar-virtual-attributes branch January 18, 2023 20:21
@shopify-shipit shopify-shipit bot temporarily deployed to production February 21, 2023 12:01 Inactive
@paracycle paracycle mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

@vinistock vinistock vinistock approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tapioca doesn't generate signatures for Active Record virtual attributes
3 participants
@bdewater @paracycle @vinistock