Add global callbacks to AASM compiler #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AASM state machines allow registering global callbacks like after_all_transitions, before_all_transactions, and so on. They accept a block that runs in the context of the record. The gem compiler creates these callbacks, but the block is of course bound to T.untyped, requiring a cast in the application code. This change extends the AASM compiler to also generate the global callbacks (in addition to the event callbacks it already generates). Since the resulting methods are typed with blocks bound to the record class, the correct type appears in application code.
KaanOzkan
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AASM state machines allow registering global callbacks like after_all_transitions, before_all_transactions, and so on. They accept a block that runs in the context of the record. The gem compiler creates these callbacks, but the block is of course bound to T.untyped. This requires the application code to always include a cast in global callback blocks.
Implementation
This change extends the AASM compiler to also generate the global callbacks (in addition to the event callbacks it already generates). Since the resulting methods are typed with blocks bound to the record class, the correct type appears in application code.
Tests
I updated the existing AASM spec to expect the global callbacks to be generated with the correct types.