Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove byebug #1398

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Remove byebug #1398

merged 1 commit into from
Feb 20, 2023

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Feb 20, 2023

Motivation

Prefer to use the official Ruby debug gem (already present). The last release of byebug was over 3 years ago.

@andyw8 andyw8 requested a review from st0012 February 20, 2023 19:00
@andyw8 andyw8 marked this pull request as ready for review February 20, 2023 19:01
@andyw8 andyw8 requested a review from a team as a code owner February 20, 2023 19:01
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anyone hasn't migrated to debug yet, I hope this guide would help (if not, please let me know).

@andyw8 andyw8 merged commit ee693ef into main Feb 20, 2023
@andyw8 andyw8 deleted the andyw8/remove-byebug branch February 20, 2023 22:09
@paracycle
Copy link
Member

Honestly I was still using pry-byebug and am sad to see it removed. Why can't we have both debug and byebug installed in dev mode?

@st0012
Copy link
Member

st0012 commented Feb 21, 2023

We are accelerating byebug's deprecation (hence pry-byebug too) because we found that having byebug loaded actually breaks debug in some cases (issue).

And this could also happen when debugging Tapioca tests because byebug is required in spec_helper. I know we can avoid this by simply not requiring byebug there. But to align with the deprecation effort, it'd be great if our projects can lead the migration first. That's why we're both 1) removing byebug and 2) setup debug integration with our projects (e.g. #1399).

So I hope we can give debug a try for a week or two. And if the inconvenience still out weights the extra features it provides, we can collect the feedback and then add pry-byebug back. WDYT?

This was referenced Feb 21, 2023
@shopify-shipit shopify-shipit bot temporarily deployed to production February 23, 2023 20:07 Inactive
@paracycle paracycle added the chore label Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants