Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It appears that #1072 introduced a bug where the
eager_load:
option was not fully threaded through to theTapioca::Loaders::Dsl.new
so it was always falling back to the default value oftrue
.Implementation
Pass the given argument to
Tapioca::Loaders::Dsl.new
Tests
There's no indication eager loading is/isn't used so there's not a straightforward way to test this specifically, but it's a one-line change that's pretty obvious.