Remove support for old Bundler API in materialize_deps #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
commented
Mar 21, 2023
lib/tapioca/gemfile.rb
Outdated
| "#{spec.name} (#{spec.version})" | ||
| end, | ||
| T::Array[String], | ||
| ) |
There was a problem hiding this comment.
This T.cast is no longer necessary, is the removal preferred?
There was a problem hiding this comment.
Not sure if it is still necessary, but it would be great if we could remove it.
Morriar
approved these changes
Mar 21, 2023
KaanOzkan
force-pushed
the
ko/bundler-api
branch
from
9fae27a
to
6562dc3
Compare
paracycle
requested changes
Mar 21, 2023
KaanOzkan
force-pushed
the
ko/bundler-api
branch
from
6562dc3
to
66dff5d
Compare
paracycle
approved these changes
Mar 21, 2023
KaanOzkan
force-pushed
the
ko/bundler-api
branch
from
66dff5d
to
35d1678
Compare
KaanOzkan
force-pushed
the
ko/bundler-api
branch
from
35d1678
to
74e06c8
Compare
KaanOzkan
commented
Mar 21, 2023
| @@ -596,6 +596,7 @@ class Secret; end | |||
| end | |||
|
|
|||
| it "must not include `rbi` definitions into `tapioca` RBI" do | |||
| @project.bundle_install | |||
There was a problem hiding this comment.
There were some flaky errors that made this test fail by processing ruby2_keywords so I added a bundle install call to ensure temporary project is in a good state before continuing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This piece of code was brittle and causes an error in the latest bundler version.
Implementation
Instead of supporting different method arity's which could keep changing in the future we can remove support for the old Bundler API. v2.2.25 has been out since July 2021. Users with old versions of Bundler will not be able to use future Tapioca versions.
Tests
Locally tested using
BUNDLER_VERSION=2.4.9 bundle exec tapioca gem --verifyand bumped the version used in tapioca to trigger CI run with latest bundler.