Implement support for has_attached_class! method
#1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1513
Implementation
As implemented
has_attached_class!is a generic construct, is defined onT::Generic, accepts the same parameters astype_member/type_templatecalls. So for all intents and purposes it is type variable without a name (or rather with an implicit, internal, name).Thus, I implemented it as yet another type variable type, which gets serialized differently. The sorting order of
has_attached_class!calls might not be grouped withtype_member/type_templatecalls, but that is not important for supporting this feature.Tests
Added test cases for the new syntax