Default to raising exception if Rails app cannot be loaded

[KaanOzkan]

Resolves #1500

Apps that want the previous functionality can use --no-halt-upon-load-error

Motivation

Current behaviour is hiding legitimate errors and requires inspecting the logs

Implementation

Raise the exception thrown from config/application.rb if the new halt-upon-load-error flag is set

Tests

Included.

[Morriar]

I wonder if we really need an option for this.

Do we really want to generate empty RBIs if the application didn't load?

[KaanOzkan]

Good question. I think originally we defaulted to rescuing the exceptions to support "edge case" apps that were unable to boot config/application.rb but still want RBI generation. For DSLs most of the compilers do depend on Rails but not necessarily all. An app could be in a strange state but they can still want FrozenRecord compiler to generate some RBIs. Without a rescue, gem loading would also fail.

Do we really want to generate empty RBIs if the application didn't load?

Due to non-rails compilers we would be generating some RBIs in tapioca dsl so I can see the usecase.

I couldn't find any user reports but I feel like the use case above was an ask. This is where it was added as a safe_require so maybe @paracycle has more context.

[paracycle]

I think we still need a flag, since users might not be able to "fix" the problem with their application being loaded, and if that is the case, then Tapioca is unable to generate anything at all. It could still be valuable for Tapioca to continue generating something in those cases, rather than nothing.

[egiurleo]

Nice! I have one question about naming -- halt-upon-load-error is descriptive but long, which might make it hard to remember. In rspec, a similar option is called fail-fast, which, imo, is super easy to remember. I'm not sure what other CLIs call this kind of option -- does the halt-upon-load-error option name come from somewhere, or conform to some already-established pattern? I'm not opposed to it, just curious if there's a more succinct option 😆

[KaanOzkan]

Nice! I have one question about naming -- halt-upon-load-error is descriptive but long, which might make it hard to remember. In rspec, a similar option is called fail-fast, which, imo, is super easy to remember. I'm not sure what other CLIs call this kind of option -- does the halt-upon-load-error option name come from somewhere, or conform to some already-established pattern? I'm not opposed to it, just curious if there's a more succinct option 😆

I'm definitely open to naming suggestions. Reason I went with this one is because the flag is only used in specific load error instance. It's indeed long but it should be used once in the config file instead of in CLI during development. If we don't think there isn't enough benefit in being explicit I'm okay with something like fail-fast 👍

[egiurleo]

I'm okay with a more descriptive flag that's only meant to be used in the config 👍🏻