Limit AutoRequireHook effect to be localized to loading the bundle
#1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
changed the title
AutoRequireHook effect to be localized to loading the bundle
Morriar
approved these changes
Jun 9, 2023
This commit limits the `require: false` override to only be enabled during the execution of a block passed to the `.override_require_false` method on `AutoRequireHook` module. This is only done while we are doing essentially what is a `Bundler.require` call. In all other cases, the `AutoRequireHook` module will be prepended to `Bundler::Dependency` but since it is not enabled, it will not do anything inside the `autorequire` method.
paracycle
force-pushed
the
uk-fix-autorequire-hook
branch
from
98efb08
to
8b6b14e
Compare
Morriar
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1528
Implementation
Move
AutoRequireHookto a separate file, and make it enabled only while executing a block passed to a singleton method on the module namedoverride_require_false. TheAutoRequireHookstill always gets prepended toBundler::Dependencybut its behaviour inautorequireis to return very early if the module is not enabled.Tests
Added a test that fails DSL compilation for a mock gem that is marked
require: falseand raises from its default require. The test passes after the fix.