Simplify check for Google::Protobuf::Map type
#1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwise-aiden
approved these changes
Jun 20, 2023
bitwise-aiden
approved these changes
Jun 20, 2023
…sage types This makes sure that the failing test added in the previous commit does not fail due to typechecking, but fails due to actually generating a repeated field type and not a map type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1533
Implementation
The key change is to use duck typing and treat any repeated field descriptor that has a
lookupmethod, and looks up non-null fields namedkeyandvalueasMaptypes.Tests
Added a failing test that passed after the change.