Prevent abort call within gem from breaking tapioca gem command

[andyw8]

Motivation

I was encountering a Parallel::DeadWorker exception when running tapioca gem on a new project:

bundler: failed to load command: tapioca (/Users/andyw8/.gem/ruby/3.1.1/bin/tapioca)
/Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:83:in `rescue in work': Parallel::DeadWorker (Parallel::DeadWorker)
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:80:in `work'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:522:in `block (4 levels) in work_in_processes'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:637:in `with_instrumentation'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:521:in `block (3 levels) in work_in_processes'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:509:in `loop'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:509:in `block (2 levels) in work_in_processes'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:219:in `block (4 levels) in in_threads'
<internal:marshal>:34:in `load': end of file reached (EOFError)
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:81:in `work'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:522:in `block (4 levels) in work_in_processes'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:637:in `with_instrumentation'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:521:in `block (3 levels) in work_in_processes'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:509:in `loop'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:509:in `block (2 levels) in work_in_processes'
	from /Users/andyw8/.gem/ruby/3.1.1/gems/parallel-1.24.0/lib/parallel.rb:219:in `block (4 levels) in in_threads'

With @Morriar's help we determined that the generation for the rdoc gem was failing:

bundle exec tapioca gem rdoc

(rdoc is a dependency of both irb and debug so this may impact a lot of people).

It outputs webrick is not found. You may need to `gem install webrick` to install webrick. and no RBI file is generated.

This is due to the abort here: https://github.com/ruby/rdoc/blob/d0074a23cc835b09d72ddd2f98d10eee4d23e1ab/lib/rdoc/servlet.rb#L10

(the Servlet class is autoloaded here).

Implementation

We re-used the with_disabled_exits mechanism Tapioca already had. But we're unsure if where we added it is at the right level.

Tests

None yet... may be tricky.

[vinistock]

The fix looks good to me, but I wonder if we should wrap the entire command in that. Is there ever a scenario where we want the code to abort or exit without that being controlled by Tapioca?

[andyw8]

I suppose there is a very small risk that someone could have a gem which does something dangerous if the real abort doesn't get called.

[Morriar]

CI failures are unrelated. I'm working on it.

[st0012]

(rdoc is a dependency of both rbi and debug so this may impact a lot of people).

By rbi, maybe you meant irb? 😉