-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate overloaded sigs for active record sum #1830
generate overloaded sigs for active record sum #1830
Conversation
5f71f4b
to
17c98e4
Compare
Is it possible to have someone add a label to and review this PR? I don't seem to be able to. |
2551133
to
82d755d
Compare
#1856 was merged, this needs a rebase. |
82d755d
to
379d0ed
Compare
@bdewater Thanks, I've rebased with I'm not sure how to handle the conflict with the RBI gem now. I can rename this helper method, but it seems this helper should take type parameters as an optional argument. |
379d0ed
to
4cf0b2a
Compare
Tapioca monkey patches the rbi gem to add |
841f887
to
7cecdc8
Compare
@bdewater - Thanks for this pointer. I didn't realize that tapioca would generate the sigs for the gem including the local monkey patches. I've updated the RBI and fixed the tests. |
@stathis-alexander can you rebase on latest |
Co-authored-by: Bart de Water <496367+bdewater@users.noreply.github.com>
7cecdc8
to
3ea0689
Compare
@KaanOzkan - Done! |
3ea0689
to
93cb91e
Compare
Motivation
Closes #1822. See discussion there for full context.
TL;DR: The current sigs are incorrect when given a block.
Tests
I believe I updated the spec here correctly.