Do not call has_presence? on Protobuf::FieldDescriptor unless method exists
#1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
force-pushed
the
emily/fix-protobuf-compiler
branch
from
6094e12
to
79dc271
Compare
egiurleo
force-pushed
the
emily/fix-protobuf-compiler
branch
from
68513a1
to
c7cb116
Compare
paracycle
reviewed
Mar 26, 2024
…hod exists `FieldDescriptor#has_presence?` was defined in `google-protobuf` version 3.26, so any application using an older version would have run into an error when compiling Protobuf DSLs. Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
egiurleo
force-pushed
the
emily/fix-protobuf-compiler
branch
from
c7cb116
to
76a3018
Compare
Morriar
reviewed
Mar 26, 2024
Co-authored-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
egiurleo
force-pushed
the
emily/fix-protobuf-compiler
branch
from
76a3018
to
62d4eca
Compare
Morriar
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1835 introduced a bug in the Google Protobuf compiler -- on versions of the google-protobuf gem older than 3.26, the
has_presence?method does not exist on theFieldDescriptorclass. Calling it during DSL RBI compilation will result in an error.Implementation
If the
has_presence?method is not defined onFieldDescriptor, callhas?instead.Tests
Added an automated test.