Update Active Record find sig to allow a block #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeParam accepts a default, which is confusing since it's not used in sigs. SigParam is the right thing to use here, and create_sig will build these from a hash.
|
Rebased this on top of #1856 since that has breaking changes. |
With a block it behaves like Enumerable#find
rzaharenkov
approved these changes
Apr 5, 2024
amomchilov
approved these changes
Apr 5, 2024
KaanOzkan
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While upgrading our app since working on #1799 I came across code that looks like
Model.where(condition: true).find { |m| m.computed_attribute == "foo" }and this doesn't fit the signatures generated. While replacingfindwithdetectwas an easy enough workaround, here's the proper fix.Tests
Updated existing tests.