Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the .ruby-version standardization #1846

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

george-ma
Copy link
Contributor

What are you trying to accomplish?

This repo is well maintained and already follows the standards we set in place. b164c0b added the .ruby-version file, a required_ruby_version is already set in the .gemspec, a Gemfile.lock is already built, etc. This PR cleans up the last remaining mentions of Ruby version outside of the .ruby-version file (last two bullet points of the list below).

What should reviewers focus on?

Important

Please verify the following before merging:

Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:

  • .ruby-version file is present with the correct Ruby version defined
  • A required_ruby_version in your gemspec is set
  • There is no Ruby version present in the dev.yml Ruby task (before: - ruby: x.x.x, after: - ruby)
  • There is no Ruby version/requirement referenced in the Gemfile (no lines with ruby <some-version>)
  • A Gemfile.lock is built with the defined Ruby version
  • The version of Rubocop installed is 1.61.0 or greater
  • There is no TargetRubyVersion defined in rubocop.yml (reads from required_ruby_version on Rubocop 1.61.0)
  • There is no Ruby argument present in ruby/setup-ruby Github Actions that do not run on a Ruby matrix (no lines with ruby-version: “x.x”)

Please merge this PR if it looks good, this PR will be merged if there isn't any activity after 4 weeks.

Follow up to: b164c0b
This commit cleans up the last remaining mentions of Ruby version outside of the `.ruby-version` file.
@george-ma george-ma requested a review from a team as a code owner March 26, 2024 19:46
@KaanOzkan KaanOzkan merged commit 05359bf into main Mar 26, 2024
34 of 35 checks passed
@KaanOzkan KaanOzkan deleted the centralize_ruby_version branch March 26, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants