Remove ActiveSupport::Deprecation silencing from loader
#1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bravehager
changed the title
ActiveSupport::Deprecation responds to silencedActiveSupport::Deprecation responds to silenced=
KaanOzkan
reviewed
May 6, 2024
bravehager
force-pushed
the
activesupport-deprecation-respond-to-silenced
branch
from
c6973ed
to
b7f5aac
Compare
bravehager
changed the title
ActiveSupport::Deprecation responds to silenced=ActiveSupport::Deprecation silencing from loader
KaanOzkan
approved these changes
May 7, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #1890
Implementation
Just check if the deprecated method is actually defined or not.Remove deprecation silencing.There's probably a longer term solution using
Rails.application.deprecators.silence { ... }but it seems like the current solution assumes we can globally silence allActiveSupport::Deprecationwarnings before the Rails application is loaded.Tests
N/A (I could be missing something, but I don't see any existing tests for this behavior)