Do not report duplicate for shim or annotations classes redefining the superclass #1912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes we want to use shims to define the parent class that Tapioca may have missed. (Example 1, 2)
Consider this file generated by Tapioca for a gem:
The user knows that
Foo
actually inherits fromBaz
and wants to fix this in a shim:Tapioca
check-shims
command will report a useless duplicated shims, yet this redefinition should be allowed:Implementation
Before reporting a shim class as a duplicate, we should check if it redefines the super class compared to the definitions we can find in the generated files.
Tests
See automated tests.