Add check command #231
Merged
Add check command #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutecipher
force-pushed
the
add-check-command
branch
from
63a162e
to
6ba6d39
Compare
mutecipher
force-pushed
the
add-check-command
branch
6 times, most recently
from
c73d648
to
c049deb
Compare
mutecipher
force-pushed
the
add-check-command
branch
11 times, most recently
from
73cd8d5
to
b794ebb
Compare
mutecipher
force-pushed
the
add-check-command
branch
3 times, most recently
from
68f8a0b
to
0ac3d8e
Compare
mutecipher
force-pushed
the
add-check-command
branch
from
228adc5
to
910c3a4
Compare
KaanOzkan
reviewed
Mar 11, 2021
KaanOzkan
reviewed
Mar 11, 2021
vinistock
reviewed
Mar 11, 2021
mutecipher
commented
Mar 11, 2021
| RBI files are out-of-date, please run `generate command` to update. | ||
| Reason: New file(s) introduced. | ||
| OUTPUT | ||
| assert_includes($?.to_s, "exit 1") # rubocop:disable Style/SpecialGlobalVars |
There was a problem hiding this comment.
Want to make a special note about this. I was intending to use Process.last_status which wasn't available in Ruby 2.4. So I opted to use this with the rubocop exception as it's just for tests to work around the IO.popen(...)
Morriar
reviewed
Mar 11, 2021
mutecipher
requested review from
RyanBrushett,
Morriar,
KaanOzkan and
vinistock
paracycle
reviewed
Mar 12, 2021
RyanBrushett
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
🎩 seems to work neatly to me!
Let's cut an issue for the refactors somewhere IMO since there are a few worth tracking.
Possible future improvement: Quieter output that just writes the result and the reason like
RBI files are out-of-date, please run `tapioca dsl` to update.
Reason: New file(s) introduced.
| option :verify, | ||
| type: :boolean, | ||
| default: false, | ||
| desc: "Verifies RBIs are up-to-date" |
There was a problem hiding this comment.
Might be worth explicitly saying that it doesn't modify anything in the description.
mutecipher
force-pushed
the
add-check-command
branch
from
c094793
to
92848f3
Compare
mutecipher
force-pushed
the
add-check-command
branch
from
92848f3
to
ac676f4
Compare
paracycle
approved these changes
Mar 12, 2021
KaanOzkan
approved these changes
Mar 15, 2021
Morriar
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need an easy way to check whether or not the RBI files are out-of-date after updates are made to files, Gems are bumped, etc. This adds a
checkcommand totapiocathat will re-generate the DSL (excluding Gems) to diff against to determine whether or nottapioca dslneeds to be run.Implementation
Create a
tmpdirusingDir.mktmpdir, generate the DSL in the temp directory, and diff against that to determine if RBIs are out of sync.The command returns with an exit status of
0if no changes are detected, and1if changes are detected. This will allow for it to be used in CI pipelines.Tests
Adds two additional tests that ensure that the command returns the correct exit code as well as messaging to advise on correct next steps.