Compile T::Enum with the enums block
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcarbs
force-pushed
the
compile-t-enum
branch
from
15a6ef0
to
ac807a5
Compare
paracycle
reviewed
Mar 2, 2021
jeffcarbs
force-pushed
the
compile-t-enum
branch
from
d05a6f7
to
2de1a62
Compare
|
@paracycle - Thanks for the suggestions. Just committed them so this should be good for another look. |
KaanOzkan
approved these changes
Mar 2, 2021
|
@jeffcarbs You had signed the CLA before, right? I think it might be our CLA bot acting up. Do you mind amending your last commit and force-pushing to trigger it again? |
Co-authored-by: Ufuk Kayserilioglu <ufuk@paralaus.com>
jeffcarbs
force-pushed
the
compile-t-enum
branch
from
2de1a62
to
2009875
Compare
|
Amending and force-pushing worked 👍 |
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With sorbet's
T::Enumthe enum values themselves are actually instances of the class that inherits fromT::Enum. Tapioca doesn't handle these specially which affects sorbet's ability to perform exhaustiveness checking. Here's a repro on sorbet.run.Implementation
Specially handle
T::Enumto define the enums using theenums do ... endblock and ignore the enum values from the normal compilation.Tests
See updated tests.