Purge stale DSL RBI files during dsl operation
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We collect the set of existing DSL RBI files in the filesystem and then remove items from the set as files are generated. Whatever we are left with in that set should be RBI files that are no longer needed. The only complication for this strategy is the fact that the user can supply a list of requested constant names, in which case, we need to build the initial list as the filenames of the RBIs that those constant names would have generated.
After we try to convert requested constant names to constants, we check to see if there were anuy failures. If there were, we display an error for each failed constant lookup and we try to delete the associated RBI file if it exists. We also exit with a non-zero exit code.
vinistock
reviewed
Mar 3, 2021
Morriar
approved these changes
Mar 3, 2021
vinistock
approved these changes
Mar 3, 2021
KaanOzkan
approved these changes
Mar 3, 2021
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Do a better job of keeping DSL RBI files in sync by removing stale RBI files during generation.
Implementation
We collect the set of existing DSL RBI files in the filesystem before we start any DSL RBI generation. We then remove items from the set as RBI files are generated. Whatever we are left with in that set should be RBI files that are no longer needed.
The only complication for this strategy is the fact that the user can supply a list of requested constant names, in which case, we need to build the initial list as the filenames of the RBIs that those constant names would have generated.
Tests
See included tests.