Allow for custom sorbet executables via TPC_SORBET_EXE env var #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
paracycle
reviewed
Mar 5, 2021
Co-authored-by: Ufuk Kayserilioglu <ufuk@paralaus.com>
Co-authored-by: Ufuk Kayserilioglu <ufuk@paralaus.com>
paracycle
reviewed
Mar 5, 2021
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #245. Allows users to specify an alternative installation path for
sorbet-staticviaTPC_SORBET_EXE, similar to theSRB_SORBET_EXEused bysrb.Implementation
The path to
sorbet-staticwas hardcoded inlib/tapioca/compilers/sorbet.rb. I added a conditional to check ifTPC_SORBET_EXEis set, and if so use that value instead. IfTPC_SORBET_EXEis not set, behavior should be unchanged.I wasn't sure where/if I should add documentation to let users know
TPC_SORBET_EXEexists. Open to suggestions!Tests
Unit tests added in
spec/tapioca/compilers/sorbet_spec.rb. I also ran my fork of tapioca on my system with my custom sorbet executable, to confirm it works. Not sure if it makes sense to add any integration or e2e tests for this change.