Change loader behaviour to support pre-Rails 6 apps #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Rails.autoloaders` did not exist in Rails pre-6.0, so we should not assume that it will be there. We were faking this by defining an `autoloaders` method on the fake `Rails` module defined in our test repo, but we really should not be doing that. Moreover, we were not actually trying to eager load a Rails app in a way that is compatible with pre-6.0 versions, which this commit aims to add as well. Fixes: #239
mutecipher
approved these changes
Mar 9, 2021
vinistock
approved these changes
Mar 9, 2021
Morriar
approved these changes
Mar 9, 2021
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes: #239
Rails.autoloadersdid not exist in Rails pre-6.0, so we should not assume that it will be there. We were faking this by defining anautoloadersmethod on the fakeRailsmodule defined in our test repo, but we really should not be doing that.Moreover, we were not actually trying to eager load a Rails app in a way that is compatible with pre-6.0 versions, which this commit aims to add as well.
Implementation
Mostly extra checks to see if methods are defined as we expect and a simplification of the test repo.
I've also added an eager loading method via
config.eager_load_namespacesthat should work in pre-6.0 apps as well. However, I am assuming thatRails.application.configwill always exist in a sensible Rails app.Tests
No extra tests.