Stop exporting internals from the gem #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
force-pushed
the
uk-fix-public-api
branch
from
6f6719d
to
cf2203a
Compare
Morriar
approved these changes
Mar 16, 2021
Morriar
reviewed
Mar 16, 2021
| @@ -859,7 +859,7 @@ def signature_of(method) | |||
| nil | |||
| end | |||
|
|
|||
| sig { params(constant: Module).returns(String) } | |||
| sig { params(constant: T::Types::Base).returns(String) } | |||
| def type_of(constant) | |||
There was a problem hiding this comment.
Actually I wonder if we should move this method as a service of T::Types::Base since we monkey patch it now?
There was a problem hiding this comment.
We don't yet monkey-patch it, but yes, that's a good idea. I'll do that once I've merged the first PR that starts the monkey-patching business.
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tapioca should have never really been exporting its internal types from the gem. All the compilers, etc are for the CLI to operate properly and should not be exported by default.
Implementation
Moved all the internal requires to
tapioca/internal.rb. Also, moved thesorbet-runtimeinitialization and configuration totapioca/cli.rbsince that is the application which should be configuring the runtime.Moving the Sorbet runtime configuration to CLI entrypoint also meant that we are running runtime typechecking during test runs now. That surfaced a few type errors that are fixed in this PR as well.
Tests
No extra added tests.