Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve binstub generation with output #267

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

paracycle
Copy link
Member

Motivation

We haven't been showing any output for binstub generation.

Implementation

Add output that bin/tapioca was created or force created depending the existence of bin/tapioca

Tests

Updated tests to check for the bin/tapioca output. Also changed test to run bundle exec tapioca and not bundle exec bin/tapioca since (a) we cannot rely on the binstub existing and (b) if running the binstub, it is meaningless to prepend a bundle exec to it.

@paracycle paracycle requested a review from a team March 22, 2021 20:20
Copy link
Contributor

@mutecipher mutecipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@paracycle paracycle merged commit 6ff3e03 into master Mar 23, 2021
@paracycle paracycle deleted the uk-add-output-for-binstub branch March 23, 2021 00:11
@mutecipher mutecipher temporarily deployed to production March 24, 2021 18:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants