Fix FixedHash serialization
#327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
force-pushed
the
uk-fix-fixed-hash-serialization
branch
from
6c1f1be
to
17c64ed
Compare
`T::Types::FixedHash` did not used to differentiate between the key types and serialized all keys as Symbols. This created an information loss when Tapioca was serializing parameters in signatures that had fixed hash values with String or mixed keys. The same change is done upstream in Sorbet in sorbet/sorbet#4223 and this is a backport of that change to older versions of Sorbet.
paracycle
force-pushed
the
uk-fix-fixed-hash-serialization
branch
from
17c64ed
to
60b46db
Compare
vinistock
approved these changes
May 25, 2021
Morriar
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
T::Types::FixedHashdid not used to differentiate between the key types and serialized all keys as Symbols. This created an information loss when Tapioca was serializing parameters in signatures that had fixed hash values with String or mixed keys.Implementation
The same change is done upstream in Sorbet in sorbet/sorbet#4223 and this is a backport of that change to older versions of Sorbet.
Tests
Added an explicit test for this case.