Treat default gems properly #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
reviewed
May 25, 2021
There was a problem hiding this comment.
If anyone else didn't know what are default gems: https://nts.strzibny.name/ruby-stdlib-default-bundled-gems/
vinistock
approved these changes
May 25, 2021
| end | ||
|
|
||
| private | ||
|
|
||
| sig { returns(T::Boolean) } | ||
| def default_gem? | ||
| @spec.respond_to?(:default_gem?) && @spec.default_gem? |
There was a problem hiding this comment.
Is the respond_to? for older versions of Bundler? When would it not respond to default_gem??
There was a problem hiding this comment.
I think so. To be perfectly honest, I cargo-culted it from some of the Bundler code that was doing similar checks so I assumed it could be an older version Rubygems, maybe.
If the version of a default gem specified in the `Gemfile` is the version of that default gem that is bundled with the Ruby version, then Bundler just uses the default gem from the Ruby library directory. This prevents Tapioca from generating a proper RBI for the gem and we end up generating an empty gem. This commit makes sure that if a gem is marked as a default gem, we check against the files listed in its gemspec inside the Ruby library folder instead of looking inside what the gem install folder would have been.
paracycle
force-pushed
the
uk-treat-default-gems-properly
branch
from
e47b89a
to
c8f1f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the version of a default gem specified in the
Gemfileis the version of that default gem that is bundled with the Ruby version, then Bundler just uses the default gem from the Ruby library directory.But Bundler still acts like the gem is installed in where it would have been, which prevents Tapioca from generating a proper RBI for the gem and we end up generating an empty gem.
Implementation
This PR makes sure that if a gem is marked as a default gem, we check against the files listed in its gemspec inside the Ruby library folder instead of looking inside what the gem install folder would have been.
Tests
No added tests.