Suppress call validation errors during CLI run #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
force-pushed
the
uk-suppress-call-validation-handlers
branch
from
4e57362
to
aa25182
Compare
RyanBrushett
approved these changes
May 25, 2021
The way we modify generic types means we sometimes are not able to properly validate inline checks or call signatures. For that reason, Tapioca tries to run with most stuff turned off. However, there is a call validation that happens inside `T::Props::Private::SetterFactory#build_setter_proc` which does not respect the `default_checked_level` value. Thus, to suppress those errors from being raised at runtime in production, we need to explicitly suppress call validation errors by setting a no-op handler.
paracycle
force-pushed
the
uk-suppress-call-validation-handlers
branch
from
aa25182
to
6553803
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The way we modify generic types means we sometimes are not able to properly validate inline checks or call signatures. For that reason, Tapioca tries to run with most stuff turned off.
However, there is a call validation that happens inside
T::Props::Private::SetterFactory#build_setter_procwhich does not respect thedefault_checked_levelvalue.Implementation
To suppress those errors from being raised at runtime in production, we need to explicitly suppress call validation errors by setting a no-op handler.
Tests
No tests.