Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never sort mixins #392

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Never sort mixins #392

merged 1 commit into from
Jul 19, 2021

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jul 15, 2021 •
edited

Motivation

Make sure the mixins are never sorted.

Tests

See automated tests.

@Morriar
Never sort mixins
224f4e3 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar requested a review from a team July 15, 2021 21:44
paracycle
paracycle approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Morriar Morriar merged commit 3a75545 into master Jul 19, 2021
@Morriar Morriar deleted the at-fix-includes-order branch July 19, 2021 15:47
paracycle pushed a commit that referenced this pull request Jul 19, 2021
@Morriar @paracycle
Merge pull request #392 from Shopify/at-fix-includes-order
fb63f4b 
Never sort mixins
@shopify-shipit shopify-shipit bot temporarily deployed to production September 7, 2021 16:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

@vinistock vinistock vinistock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Morriar @paracycle @vinistock