Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DSL generation also autocorrect the gems RBI strictnesses #837

Merged
merged 3 commits into from Mar 1, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Mar 1, 2022

Motivation

We introduced this feature in #801 but triggered it only when running tapioca gem.

I think it also makes sense to trigger the autocorrect of strictness after a tapioca dsl since the generated DSL files might clash with the generated gem files.

Implementation

  • Renamed RBIHelper into SignaturesHelper
  • Extracted update_gem_rbis_strictnesses into a new RBIHelper
  • Added a call to update_gem_rbis_strictnesses right after the DSL files generation

Tests

See added tests.

Morriar added 2 commits Mar 1, 2022
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the enhancement label Mar 1, 2022
@Morriar Morriar added this to the Tapioca 1.0 milestone Mar 1, 2022
@Morriar Morriar requested a review from Mar 1, 2022
@Morriar Morriar self-assigned this Mar 1, 2022
spec/tapioca/cli/dsl_spec.rb Outdated Show resolved Hide resolved
@Morriar Morriar changed the title Make DSL generation also autocorrect the gems RBI strrictnesses Make DSL generation also autocorrect the gems RBI strictnesses Mar 1, 2022
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar merged commit 4754fc1 into main Mar 1, 2022
8 checks passed
@Morriar Morriar deleted the at-typed-override branch Mar 1, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to production May 13, 2022 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants