Skip debug and fakefs gems #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These 2 gems are dev/test only gems and have been proven to be disrupting to RBI generation. So instead of telling every users to skip them manually, Tapioca should just skip them by default.
st0012
force-pushed
the
skip-problematic-gems
branch
from
2cbd88c
to
cc35b00
Compare
KaanOzkan
approved these changes
May 30, 2022
Morriar
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
These 2 gems are dev/test only gems and have been proven to be
disrupting to RBI generation. So instead of telling every users to skip
them manually, Tapioca should just skip them by default.
Implementation
Just add them to the
IGNORED_GEMSconstant.Tests
I'm not sure if we want to add tests for this the ignored gems list?
Closes #946