Use --config and --postrequire when calling the init command
#957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
vinistock
approved these changes
Jun 1, 2022
egiurleo
reviewed
Jun 1, 2022
| def init | ||
| command = Commands::Init.new( | ||
| sorbet_config: SORBET_CONFIG_FILE, | ||
| tapioca_config: TAPIOCA_CONFIG_FILE, |
There was a problem hiding this comment.
For my own understanding: where did this TAPIOCA_CONFIG_FILE originally come from?
There was a problem hiding this comment.
Most of the path constants are defined here: https://github.com/Shopify/tapioca/blob/main/lib/tapioca.rb#L29
The same constant is used as default value for the option here: https://github.com/Shopify/tapioca/blob/main/lib/tapioca/cli.rb#L18
KaanOzkan
approved these changes
Jun 1, 2022
egiurleo
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed that we were defining the option
--configat the top level and loaded the configuration from the path provided by this option yet, we always created the config at a fixed location when callingtapioca init.Same for the
require.rbfile. It was loaded from the path provided through the--postrequireoption yet the file was always created at a fixed path when callingtapioca init.Tests
See automated tests.