Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the help block from the README #958

Merged
merged 4 commits into from
Jun 1, 2022
Merged

Generate the help block from the README #958

merged 4 commits into from
Jun 1, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented May 31, 2022

Motivation

I noticed that the verbatim code blocks showing the content of the help command was out-of-date.

While we generate the help for the different commands we didn't generate the root help of Tapioca.

This PR addresses this problem and update the README accordingly.

Implementation

In the readme.rake:

  1. Renamed print_commands_help
  2. Added print_help
  3. Fixed a few sh into shell for uniformity

I also fixed the terminal width used by the FakeShell to ensure local and CI runs would produce the same output. Before this PR, CI was truncating the help lines at 80 chars which may be different from local config.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar requested a review from a team May 31, 2022 23:45
@Morriar Morriar self-assigned this May 31, 2022
@Morriar Morriar force-pushed the at-readme branch 2 times, most recently from 060270a to 9c995dc Compare May 31, 2022 23:55
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just learnt that command helps document are generated automatically. It's super neat!

@Morriar Morriar merged commit 4d8ce49 into main Jun 1, 2022
@Morriar Morriar deleted the at-readme branch June 1, 2022 15:44
@shopify-shipit shopify-shipit bot temporarily deployed to production July 7, 2022 17:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants