Support authentification for private annotations repositories #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
force-pushed
the
at-private-repos
branch
2 times, most recently
from
8e83761
to
a02a98a
Compare
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
So we can pass headers later. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
We need at least one index to work. If a source is down, we show an error but we can still fetch annotations. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
KaanOzkan
approved these changes
Jun 3, 2022
vinistock
approved these changes
Jun 6, 2022
|
About the tests, I'm not sure what would be the best way to test with a private repo: we would need to create one just for tests, store the token somewhere in the Github action, find a way to pass it to contributors so they can test locally etc. @KaanOzkan, @vinistock any idea? |
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
…README Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-private-repos
branch
2 times, most recently
from
0fa9c05
to
4b0aa3b
Compare
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-private-repos
branch
from
4b0aa3b
to
bf02ee3
Compare
This will make it easier to test the command itself. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-private-repos
branch
from
bf02ee3
to
ad2edea
Compare
|
As discussed offline, I added a test using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow users to import RBI annotations from private repositories. This is useful when using private gems for example.
Closes #962.
Implementation
Since we access the private repository files through http, the easiest way to go is to pass the
Authentificationheader as well. This header can be provided by the user through the--authoption:See the readme for more information.
Next step
Once we are able to provide the authentication (this PR), the next logical step will be to read this authentication from the netrc file.
Tests
See automated tests.