Check-shims command also look inside the sorbet/rbi/annotations directory #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
paracycle
approved these changes
Jun 14, 2022
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
…tory Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since we now pull annotations from remote sources, it is possible they make some local shims redundant.
With this PR, Tapioca also loads the contents of the
sorbet/rbi/annotationsdirectory to check for duplicates.Fixes #960.
The first commit only moves the code of
check-shimsinside a command as to clean thecli. Relevant changes are in the following commits.Tests
See automated testing.