Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --typed-overrides option to the annotations command #999

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jun 16, 2022

Motivation

Sometimes the annotations files pulled by Tapioca will create type errors in your project because of incompatibilities.
It is possible to ignore such files by switching their strictness level --typed-overrides option:

$ bin/tapioca annotations --typed-overrides gemA:ignore gemB:false

Or through the configuration file:

annotations:
  typed_overrides:
    gemA: "ignore"
    gemB: "false"

Fixes #961.

Tests

See automated tests.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the enhancement New feature or request label Jun 16, 2022
@Morriar Morriar requested a review from a team June 16, 2022 19:57
@Morriar Morriar self-assigned this Jun 16, 2022
@Morriar Morriar merged commit ba9b60a into main Jun 22, 2022
@Morriar Morriar deleted the at-annotations-typed-overrides branch June 22, 2022 18:13
@shopify-shipit shopify-shipit bot temporarily deployed to production July 7, 2022 17:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

annotations command should support ignoring specific gem annotations
3 participants