theme check fails, but action passes

[Morgy93]

I just ran this GitHub action on a fresh Shopify/dawn v2.3.0 and the theme-check throws this Shopify/dawn#686 error, but the check passes nonetheless:

Maybe that's the cause why it got in the release in the first place?

I'd assume that the theme-check-action does not "catch" any errors then.

[charlespwd]

It's because the default error level is "error". Suggestions are like warnings, you can pass CI without them.

If you want to change this behaviour, you can set the flags option to the following:

# .github/workflows/theme-check.yml
name: Theme Check
on: [push]
jobs:
  theme-check:
    name: Theme Check
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - name: Theme Check
        uses: shopify/theme-check-action@v1
        with:
          theme_root: '.'
          flags: '--fail-level suggestion' # this means run theme-check --fail-level suggestion