Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing lazy loading tag for theme-check #686

Closed

Conversation

chanonroy
Copy link
Member

Why are these changes introduced?

Upon using theme-check from main branch, I noticed that the linter considers the missing loading='lazy' tag on the predictive search images to be an offense.

Screenshot 2021-09-24 at 10 19 15 AM

What approach did you take?

Adding the loading='lazy' tag to predictive search images

Other considerations

Perhaps this tag was intentionally omitted for this use case since the predictive search occurs higher up in the user's viewport? In which case, is there a good way to make the theme-check linter less strict about lazy loading?

Demo links

Checklist

@ghost ghost added the cla-needed label Sep 24, 2021
ghost
ghost previously approved these changes Sep 30, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Was about to push the same PR. Good job.

@chanonroy chanonroy closed this Mar 1, 2022
@chanonroy chanonroy deleted the predictive-search-loading-lazy branch March 1, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant