Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intelligent code completion] Support iterated objects via for, inside form #681

Closed
Poitrin opened this issue Dec 13, 2022 · 0 comments · Fixed by #685
Closed

[Intelligent code completion] Support iterated objects via for, inside form #681

Poitrin opened this issue Dec 13, 2022 · 0 comments · Fixed by #685
Assignees
Labels
bug Something isn't working

Comments

@Poitrin
Copy link
Contributor

Poitrin commented Dec 13, 2022

Describe the bug
In the following example, when a for loop is inside a form, ICC doesn't seem to work.

{%- form 'localization', id: 'FooterLanguageFormNoScript', class: 'localization-form' -%}
  {%- for language in localization.available_languages -%}
    <option value="{{ language.⬜️

Simplified version of https://github.com/Shopify/dawn/blob/main/sections/footer.liquid#L276

Expected
Expected suggestions like iso_code.
Expected suggestions like iso_code

Actual
Default suggestions from VS Code
Default suggestions from VS Code

Debugging information

  • OS [e.g. Windows, Mac, Linux]: macOS
  • Version (output of theme-check --version in a terminal): 1.12.0
@Poitrin Poitrin added the bug Something isn't working label Dec 13, 2022
@karreiro karreiro self-assigned this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants