Introduce support to range iterations and SFR tags #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce support to range iterations - `AssignmentsCompletionProvider` no longer crashes when it finds an unexpected lookup
This was
linked to
issues
Dec 14, 2022
Poitrin
reviewed
Dec 14, 2022
There was a problem hiding this comment.
Impressive work! 😮
I just found one little bug in this scenario:
{%- assign number_of_slides = 4 %}
{%- for i in (1..number_of_slides) -%}
<div id="Slide-{{ block.
You even thought of this case in test_assignments_finder_with_for_statements_and_complex_ranges, but, alas, the range starts with a literal number and ends with a variable x)
|
Thank you, @Poitrin! Excellent catch 🚀 I've applied the fix in a new commit :) |
Poitrin
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #681, #682, and #684
(I've opened a single PR because the fixes intersect a bit in the code, and I'd have dependent PRs)
[Intelligent code completion] Support iterated objects via
for, insideform#681TolerantParser[Intelligent code completion] Do not log an error when preceding
assigned value is not mentioned in the docs #682AssignmentsCompletionProviderno longer crashes when it finds an unexpected lookup[Intelligent code completion] Do not log an error with ranges #684
Scopeclass now supports literal ranges