New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for nested liquid loops #436

Open

darryn opened this issue Jul 1, 2021 · 1 comment

Labels

area:theme-check enhancement

darryn commented Jul 1, 2021

There are instances where there are multiple liquid loops nested inside each other. These can clog the TTR.

Here is a bad example...

  {% for product in collection.products %}
    {% for tag in product.tags %}
      {% for variant in product.variants %}
        {% for collection in product.collections %}
        
        {% endfor %}
      {% endfor %}
    {% endfor %}
  {% endfor %}

Semi-related to the nested snippets logic.

Contributor

macournoyer commented Jul 5, 2021

Oh this is good Darryn! Thanks for the suggestion.

Darhazer mentioned this issue

Add new NestedLoop check Shopify/theme-check#719

Closed

lukeh-shopify transferred this issue from Shopify/theme-check

lukeh-shopify added enhancement area:theme-check labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment