Add support for # inline comment tag
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
changed the title
# inline comment tag
|
@charlespwd this seems to have been pushed live now. Seems to work fine on my stores |
|
Hmm. Should probably bug them. It's still "unreleased" even though we use it in prod. https://github.com/Shopify/liquid/blob/master/History.md#features |
|
I still have the issue. |
charlespwd
force-pushed
the
feature/new-comment-syntax
branch
from
d542e73
to
c98f265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#inline comment tag is coming. This PR adds support for it in theme-check.Looking forward to using this 馃憤:
Instead of this 馃憥 :
Currently blocked until Shopify/liquid#1498 is merged and we have a new Liquid release.