Added a DeprecatedTags check
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haribshahbaz
force-pushed
the
convert-include-to-render
branch
from
a78d864
to
459907c
Compare
haribshahbaz
changed the title
DeprecatedTags check
haribshahbaz
force-pushed
the
convert-include-to-render
branch
from
7143cb3
to
9ab0e9b
Compare
albchu
reviewed
Aug 30, 2023
| '@shopify/theme-check-docs-updater': minor | ||
| --- | ||
|
|
||
| Add `DeprecatedTags` check |
There was a problem hiding this comment.
Glad to see this working for ya now!
albchu
previously requested changes
Aug 30, 2023
| meta: { | ||
| code: 'DeprecatedTags', | ||
| name: 'Deprecated Tags', | ||
| docs: { |
There was a problem hiding this comment.
For the doc url, may we add: https://shopify.dev/docs/themes/tools/theme-check/checks/deprecated-tags here?
As a fast followup, you will also need to do some light housekeeping on the dev docs.
Basically what we need is:
- convert-include-to-render docs copied for a new link address
https://shopify.dev/docs/themes/tools/theme-check/checks/deprecated-tagswith light modifications. - The old convert-include-to-render docs should get a new banner saying that the check has been migrated to typescript as deprecated-tags (with a link to the new documentation)
albchu
dismissed
their stale review
Spoke with Harib and he would like to wait on some followup input from CP regarding some bonus objectives for this change.
|
Spoke to CP regarding the bonus requirements for this check. He mentioned it being overly complicated at the moment, and that we would get back to it when time permits. |
2 tasks
haribshahbaz
force-pushed
the
convert-include-to-render
branch
from
bcc3940
to
12c794a
Compare
albchu
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/Shopify/theme-check-js/issues/47
What are you adding in this PR?
This PR is adding a
DeprecatedTagscheck (for more context on why I took this approach, please read this comment). Under the deprecated tags check, we can add specific cases to deprecated tags that we would like to check for. This PR adds theConvertIncludeToRendercheck which essentially converts a liquid tag that usesincludeto userenderasincludeis deprecated.What's next? Any followup issues?
If we need to check for any other deprecated tags, it should be written under this check as a specific case.
TopHat Screenshots
Before you deploy
changesetallChecksarray insrc/checks/index.tsyarn update-configsand committed the updated configuration files