Fixing folder events in file watcher #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanema
commented
Jan 25, 2021
| if len(events) == 0 { | ||
| return false | ||
| } | ||
|
|
||
| drainTimer := time.NewTimer(drainTimeout) | ||
| defer drainTimer.Stop() | ||
| for { |
There was a problem hiding this comment.
The actual issue is on line 143 where we get a second stage of events, the directory event filtering from line 125 was not duplicated there.
andyw8
reviewed
Jan 25, 2021
| events := map[string]Event{} | ||
| for _, event := range w.translateEvent(event) { | ||
| events[event.Path] = event | ||
| for _, e := range w.translateEvent(event) { |
There was a problem hiding this comment.
[optional] perhaps rename e to translatedEvent?
andyw8
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #885
why
The file watcher would only originally catch directory events if they were the first event before the event buffer was started. This was because normally the event buffer is used to catch duplicate events or quick events like swap files which move and write at the same time. However there are some editors that touch the directory along with the file that was edited so the file edit event would come first, and the mod of the directory second, causing themekit to miss that event and it getting flushed through the rest of the system.
Fix
The directory event handling has been moved to the event translation step so that it will convert directory events into noops. This is a more central place to do this.
Warn Checklist