Add messaging Theme Kit Access messaging and flag to suppress it #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenxie
force-pushed
the
add-themekit-access-messaging
branch
from
89d7ea0
to
d8140d1
Compare
tanema
approved these changes
Jun 14, 2021
eloyesp
reviewed
Jul 20, 2021
| @@ -89,6 +102,7 @@ func init() { | |||
| ThemeCmd.PersistentFlags().StringArrayVar(&flags.Ignores, "ignores", []string{}, "A path to a file that contains ignore patterns.") | |||
| ThemeCmd.PersistentFlags().BoolVar(&flags.DisableIgnore, "no-ignore", false, "Will disable config ignores so that all files can be changed") | |||
| ThemeCmd.PersistentFlags().BoolVar(&flags.AllowLive, "allow-live", false, "Will allow themekit to make changes to the live theme on the store.") | |||
| ThemeCmd.PersistentFlags().BoolVarP(&flags.DisableThemeKitAccessNotifier, "no-theme-kit-access-notifier", "", false, "Stop theme kit from notifying about Theme Kit Access.") | |||
There was a problem hiding this comment.
What is the point of using BoolVarP with an empty string instead of BoolVar?
|
Hi, it seems that this flag is not documented on https://shopify.dev/themes/tools/theme-kit/configuration-reference#global-parameters Also, I found no way to disable it on the config file. Regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Theme Kit Access app is in beta now. When we move to GA, we want to encourage developers to make the switch by adding messaging to the Theme Kit CLI. This PR adds that message and a flag to be able to suppress it.
Part of https://github.com/Shopify/themekit-access/issues/147
Warn Checklist