Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test-e2e script #431

Closed
wants to merge 1 commit into from
Closed

Update test-e2e script #431

wants to merge 1 commit into from

Conversation

miry
Copy link
Contributor

@miry miry commented Sep 3, 2022

Extract execution of benchmark script to function.
Use alias for command lines.
Extract trap eval string to function.

@miry miry self-assigned this Sep 3, 2022
@miry miry added the Toxiproxy label Sep 3, 2022
@miry miry marked this pull request as ready for review September 3, 2022 23:45
@miry miry added this to the 2.5.0 milestone Sep 3, 2022
@miry miry mentioned this pull request Sep 3, 2022
18 tasks
Copy link

@barthalion barthalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks, feel free to ignore if they don't make sense in wider context.

scripts/test-e2e Outdated Show resolved Hide resolved
scripts/test-e2e Outdated Show resolved Hide resolved
@miry miry force-pushed the test-e2e-reformat branch 2 times, most recently from 4995733 to ad8e399 Compare September 5, 2022 13:00
@miry miry force-pushed the test-e2e-reformat branch 2 times, most recently from 9116a52 to 51c6c2f Compare September 5, 2022 13:40
Extract execution of benchmark script to function.
Use alias for command lines.
Extract trap eval string to function.
@miry
Copy link
Contributor Author

miry commented Sep 5, 2022

merged in commit 29685f4

@miry miry closed this Sep 5, 2022
@miry miry deleted the test-e2e-reformat branch September 5, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants