Improve with logging deep components #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
propogate-logger
branch
from
8b3a106
to
6a102ec
Compare
miry
requested review from
a team,
jgaskins,
djlebersilvestre and
dabealu
and removed request for
a team
miry
commented
Sep 5, 2022
| } | ||
|
|
||
| func timeoutMiddleware(next http.Handler) http.Handler { | ||
| return http.TimeoutHandler(next, 30*time.Second, "") |
There was a problem hiding this comment.
Increased timeout from 5 seconds to 30 seconds.
thepwagner
approved these changes
Sep 6, 2022
Propogate context with logger to ToxicCollection, ToxicLink.
miry
force-pushed
the
propogate-logger
branch
from
6a102ec
to
dc4b9e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propogate context with logger to ToxicCollection, ToxicLink.