Expose CustomerSegmentTemplate icon and category types
#1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrescilliaA
force-pushed
the
pa/make-category-and-source-public
branch
from
0d6dca4
to
87470ba
Compare
LTiger14
approved these changes
Aug 22, 2023
lauramann
reviewed
Aug 22, 2023
PrescilliaA
force-pushed
the
pa/make-category-and-source-public
branch
from
87470ba
to
f4d0ea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Right now we are duplicating the icon and category types on web, and this makes 2 sources of truth for template icon sources and categories to maintain.
Solution
Exposing both the array and type publicly will help clean up web, and result in less maintenance in the long term.
Checklist